[#3535] Send messages to Whatsapp Cloud #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2022 16:09
|
|
chrismatix
commented
Aug 24, 2022
| @@ -184,7 +184,7 @@ void canSendTagEvents() throws Exception { | |||
| private static StompSession connectToWs(int port) throws ExecutionException, InterruptedException { | |||
| final WebSocketStompClient stompClient = new WebSocketStompClient(new StandardWebSocketClient()); | |||
| MappingJackson2MessageConverter messageConverter = new MappingJackson2MessageConverter(); | |||
| ObjectMapper objectMapper = new ObjectMapper().setPropertyNamingStrategy(PropertyNamingStrategy.SNAKE_CASE); | |||
There was a problem hiding this comment.
Also refactored this deprecated import
chrismatix
commented
Aug 24, 2022
| @@ -88,6 +88,7 @@ public List<KeyValue<String, SpecificRecordBase>> sendMessage(SendMessageRequest | |||
| results.add(KeyValue.pair(getId(errorPayload).toString(), errorPayload)); | |||
| } | |||
| updateDeliveryState(message, DeliveryState.FAILED); | |||
| results.add(KeyValue.pair(message.getId(), message)); | |||
There was a problem hiding this comment.
This fixes a sofar unknown bug
chrismatix
commented
Aug 24, 2022
| @Configuration | ||
| public class MetaConfig { | ||
| @Bean | ||
| @Qualifier("metaObjectMapper") |
There was a problem hiding this comment.
So far the meta-object mapper has been the same as ours in terms of config. It's better however to explicitly split them.
| .build()) | ||
| )); | ||
|
|
||
| TimeUnit.SECONDS.sleep(5); |
There was a problem hiding this comment.
with the following attributes
kafka.commit-interval-ms=0
kafka.cache.max.bytes=0
You should not need to wait that long, 100ms will be enough? Also there is other way to get around the sleep time?
There was a problem hiding this comment.
Just tested this and it doesn't make a difference. I think that this time is genuinely spent on catching up with the streams app.
juan-sebastian
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3535